Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): compatible hooks strategy for old libs sdk #5029

Merged
merged 2 commits into from Apr 22, 2022

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Apr 22, 2022

@pengx17
Copy link
Contributor

pengx17 commented Apr 22, 2022

@xyhp915 Not sure what changed in the plugin API since last nightly, so this is a compatibility fix in this PR right?

@xyhp915
Copy link
Collaborator Author

xyhp915 commented Apr 22, 2022

Not sure what changed in the plugin API since last nightly, so this is a compatibility fix in this PR right?

Yes. It's just a compatibility fix for the old plugin sdk. Because the new plugin system has enhanced messaging strategy for better performance.

Copy link
Contributor

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 1963a97 into master Apr 22, 2022
@andelf andelf deleted the fix/compatiable-hooks-for-old-plugin-sdk branch April 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants