Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update rsapi to resolve windows crash #5264

Merged
merged 1 commit into from May 10, 2022

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented May 9, 2022

Fix Windows crash.
Fix Linux crash warning on libssl missing.

  • revert to old napi-rs
  • rm native-tls

See-also: napi-rs/napi-rs#1175

Fix #5263
Close #5154
Close #4956

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing quick! 👍 ⚡

@andelf andelf changed the title fix(build): update rsapi to 0.0.10 fix(build): update rsapi to resolve windows crash May 10, 2022
@andelf andelf merged commit 504b47b into master May 10, 2022
@andelf andelf deleted the andelf-fix-windows-lib branch May 10, 2022 02:39
@menelic
Copy link

menelic commented May 10, 2022

Thanks for the quick fix, unfortunately it still does not work on linux #5263 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants