fix: missing db persistency when creating new window via file menu #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnrpman
force-pushed
the
fix-file-menu-new-window-db-persistency
branch
2 times, most recently
from
24a0b99
to
d7d97c3
Compare
tiensonqin
reviewed
Jun 8, 2022
cnrpman
force-pushed
the
fix-file-menu-new-window-db-persistency
branch
4 times, most recently
from
252b65d
to
4a01b42
Compare
|
Also fix the lint warning on the current master branch
|
cnrpman
force-pushed
the
fix-file-menu-new-window-db-persistency
branch
3 times, most recently
from
6bceb24
to
c7d87e8
Compare
cnrpman
force-pushed
the
fix-file-menu-new-window-db-persistency
branch
from
c7d87e8
to
1062719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5599
P.S. The new window shortcut config is currently overridden by the file menu config in electron core. Should decide where the shortcut to be handled.