Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable gesture on query table and logbook #5784

Merged
merged 5 commits into from Jun 27, 2022
Merged

Disable gesture on query table and logbook #5784

merged 5 commits into from Jun 27, 2022

Conversation

llcc
Copy link
Contributor

@llcc llcc commented Jun 22, 2022 •
edited

  1. Disabled gestures on query table, logbook, excalidraw . fix Mobile gestures conflict with scroll on query table and logbook #5783, Drawing tablet input problem #5837
  2. Disable gestures on blocks with customized tags in config.edn 
    :mobile
{:gestures/disabled-in-block-with-tags ["kanban"]}
  3. Increase the threshold to activate gestures to avoid conflicts with scroll.

@llcc llcc requested review from andelf and tiensonqin June 22, 2022 03:30
andelf
andelf reviewed Jun 23, 2022
View reviewed changes
src/main/frontend/handler/block.cljs Outdated
[target]
(let [user-defined-tags (get-in (state/get-config)
[:mobile :gestures/disabled-in-block-with-tags])]
(prn (some #(.closest target (util/format "[data-refs-self*=%s]" %))
Copy link
Collaborator

@andelf andelf Jun 23, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debug print deliberate?

@llcc llcc force-pushed the disable-gesture-on-query-table-and-logbook branch from 92d33d4 to b033bae Compare June 23, 2022 15:13
andelf
andelf approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf requested a review from cnrpman June 27, 2022 03:29
@tiensonqin tiensonqin merged commit c120bd9 into master Jun 27, 2022
@tiensonqin tiensonqin deleted the disable-gesture-on-query-table-and-logbook branch June 27, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@tiensonqin tiensonqin Awaiting requested review from tiensonqin

@cnrpman cnrpman Awaiting requested review from cnrpman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile gestures conflict with scroll on query table and logbook
3 participants
@llcc @andelf @tiensonqin