Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inline html markup element conversion #5954

Merged
merged 4 commits into from Jul 12, 2022

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Jul 7, 2022

  • support marked code, bold code, italic code
  • better handling of HTML inline markup element
  • fix wrong markup symbols for markdown

CSS tested against:
image

@andelf andelf requested review from xyhp915, tiensonqin, cnrpman and llcc and removed request for xyhp915 July 7, 2022 10:48
:ins
:del
:ins :u
:del :s :strike
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing inline markup elements

:markdown
"__"
:markdown ;; no underline for markdown
""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<u>/<ins> is used for underline in markdown

@andelf andelf merged commit ccc37e9 into logseq:master Jul 12, 2022
@andelf andelf deleted the refactor/inline-em-html-conversion branch July 12, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant