Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for page bouncing for lazy loading #5973

Merged
merged 4 commits into from Jul 11, 2022
Merged

Conversation

tiensonqin
Copy link
Contributor

The root cause of page bouncing on the journals page is because of lazy rendered empty linked references.
The fix is to not render empty references at all.

Also, the last time when in-view's state changes will be recorded to prevent loop switching between the lazy loading placeholder and the real content.

related to #5972

Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It fixes for me.

@andelf andelf merged commit d1979a0 into master Jul 11, 2022
@andelf andelf deleted the fix/lazy-bouncing branch July 11, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants