feat: hide journals in page graph #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add "Show Journals" toggle in page-graph-inner add :right-side-bar/show-journals in en and it (dicts.cljc) add "include-journals" parameter to db/get-pages-that-mentioned-page add "show-journal" parameter to graph-handler/build-page-graph
logseq-cldwalker
requested changes
Jul 22, 2022
There was a problem hiding this comment.
@8N9KT This looks great. As you're modifying a db namespace, it would be helpful to have a test to demonstrate this feature works as described. Could you add such a test to model_test.cljs? Some tips for testing:
- See https://github.com/logseq/logseq/blob/master/docs/dev-practices.md#unit-testing for running tests. Focus tests are probably easiest for just running your tests
- There's already an example in your test file and there are more examples in https://github.com/logseq/logseq/blob/master/src/test/frontend/db/query_dsl_test.cljs for examples. Use
load-test-filesto create files andtest-helper/test-dbis therepovalue to pass to your db function
Happy to answer any questions as they come up
- add test for get-pages-that-mentioned-page with show-journal paramenter - comment deleted
logseq-cldwalker
approved these changes
Jul 25, 2022
| @@ -82,4 +82,33 @@ | |||
| ;; 1 (count a-ref-blocks) | |||
| ;; (set ["b" "c"]) (set alias-names)))) | |||
|
|
|||
| (deftest ^:focus get-pages-that-mentioned-page-with-show-journal | |||
There was a problem hiding this comment.
Normally we remove metadata after using them since it can effect someone else trying to run the same focused tests. I don't mind removing this one but would be good to remove these in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add toggle in page graph the hide journals page
Note: only the journals which mention page are hidden, the journals which are mentioned by the page remain visible