Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alignment of macOS icon #6127

Merged
merged 2 commits into from Jul 21, 2022

Conversation

gavinmn
Copy link
Contributor

@gavinmn gavinmn commented Jul 20, 2022

I noticed that the macOS icon was incorrectly centered about 8px too high. I made a faithful recreation of the original icon as a quick fix for this issue. Some diffs to illustrate the difference:
CleanShot 2022-07-20 at 19 47 20@2x
diff
CleanShot 2022-07-20 at 19 49 52@2x

Copy link
Contributor

@scheinriese scheinriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great catch! 🧐🙌 The recreation of the logo looks good to me and the alignment optimization is ready for merge.

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavinmn Thanks for catching this and your first contribution 👍 🚢

@logseq-cldwalker logseq-cldwalker merged commit b3f2b4f into logseq:master Jul 21, 2022
@gavinmn gavinmn deleted the gavinmn/fix-big-sur-icons branch July 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants