fix: keep the favorites item when publishing

[maxweilun1989]

Hi @cnrpman , keep the config/publishing? is true as we discussed. Sorry for introducing some bugs for this project.

[tiensonqin]

@maxweilun1989 One problem is that the favorites might contains some pages that are not public.

[maxweilun1989]

@maxweilun1989 One problem is that the favorites might contains some pages that are not public.

OK, that is new to me. So we need hide favorites when it contains private pages?
Maybe keep the favorites but filter the private pages under it may be a better solution.

[tiensonqin]

@maxweilun1989 Exactly! If all pages are public, you can get that by frontend.state/all-pages-public?, there's no need to filter, otherwise, you can get all the public pages by frontend.db.model/get-public-pages and remove those private pages.

[cnrpman]

We can merge this PR first, as it's recovering the previous behavior?

[andelf]

LGTM

[andelf]

We can merge this PR first, as it's recovering the previous behavior?

Added a TODO #6334