Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when opening folder on some Android platforms #6315

Merged
merged 5 commits into from Aug 11, 2022
Merged

Fix crash when opening folder on some Android platforms #6315

merged 5 commits into from Aug 11, 2022

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Aug 10, 2022 •
edited

Fix open folder crash on some Android OS.

  • handle raw: URI for HarmonyOS and old Android OS
  • handle external storage (partially, works for most platforms)
  • Feature: experimental support of Termux integration

Related #3789

Tested:

  • Huawei Mate 30 HarmonyOS
  • OnePlus 7T with external USB Mass Storage
  • Samsung Galaxy Tab S7+ with SD card, with Termux integration

@andelf andelf changed the title fix(android): handle raw: uri for some devices Fix crash on Huawei Mate 30 HarmonyOS: handle raw: uri for some devices Aug 10, 2022
@andelf andelf changed the title Fix crash on Huawei Mate 30 HarmonyOS: handle raw: uri for some devices Fix crash when opening folder on some Android platforms Aug 10, 2022
cnrpman
cnrpman approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit bb697a1 into master Aug 11, 2022
@andelf andelf deleted the fix/android-10-raw-uri branch August 11, 2022 01:34
This was referenced Aug 11, 2022
Closed
Closed
Closed
Closed
Closed
@YlanAllouche YlanAllouche mentioned this pull request Aug 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnrpman cnrpman cnrpman approved these changes

@tiensonqin tiensonqin Awaiting requested review from tiensonqin

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andelf @cnrpman