Fix: performance degradation #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiensonqin
force-pushed
the
fix/performance-degradation
branch
from
40c49b6
to
19af037
Compare
tiensonqin
commented
Aug 15, 2022
| (not (.contains (.-classList target) "ignore-outside-event"))) | ||
| (on-hide state e :click))))] | ||
| (when-not (false? outside?) | ||
| (listen state js/window "mouseup" click-fn))) |
There was a problem hiding this comment.
This fixed the issue that the dropdown modal is not closed when editing a block.
https://www.loom.com/share/9241a366ed7548b6a73877b8c790c96f
tiensonqin
commented
Aug 15, 2022
| (recur (conj result parent) parent) | ||
| result)))) | ||
|
|
||
| (defn- get-blocks-parents-from-both-dbs |
There was a problem hiding this comment.
Need parents from both dbs because some refs could be deleted from the previous db.
tiensonqin
force-pushed
the
fix/performance-degradation
branch
from
decc7ce
to
6f2a203
Compare
cnrpman
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avetindex to speed updb/get-block-children-idsquery-state, the result is that editing in both queries and linked references will be fast compared to the master branch:block/path-refsnot re-computed when moving blocks up/down