fix: CJK hashtag update failure #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnrpman
force-pushed
the
fix-hashtag-CJK-update
branch
2 times, most recently
from
00e7512
to
ca40183
Compare
cnrpman
force-pushed
the
fix-hashtag-CJK-update
branch
from
ca40183
to
6535696
Compare
logseq-cldwalker
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
@cnrpman Thanks for fixing with tests! 🐛 ⚡ QAed and works great
| (-> (util/replace-ignore-case content (str "^" old-tag "\\b") new-tag) | ||
| (util/replace-ignore-case (str " " old-tag " ") (str " " new-tag " ")) | ||
| (util/replace-ignore-case (str " " old-tag "$") (str " " new-tag))))) | ||
| ;; hash tag parsing rules https://github.com/logseq/mldoc/blob/701243eaf9b4157348f235670718f6ad19ebe7f8/test/test_markdown.ml#L631 |
tiensonqin
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6451
Notice: This is not a new bug introduced in recent version. This is a legacy bug.