Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/plugin APIs #7555

Merged
merged 61 commits into from Dec 19, 2022
Merged

Enhance/plugin APIs #7555

merged 61 commits into from Dec 19, 2022

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Dec 2, 2022

Todos

  • feat: Support block content slot hook App.onBlockRendererSlotted with a specific block UUID onBlockRendererSlotted hook is not working #7518
  • feat: Support plugins calling each other App.invokeExternalPlugin with key of models & commands.
    E.g. (It is recommended that the caller plugin upgrade the SDK to the latest.)
    // Defined at https://github.com/xyhp915/logseq-journals-calendar/blob/main/src/main.js#L74
    await logseq.App.invokeExternalPlugin('logseq-journals-calendar.models.goToToday')
    
    // Defined at https://github.com/vipzhicheng/logseq-plugin-vim-shortcuts/blob/bec05aeee8/src/keybindings/down.ts#L20
    await logseq.App.invokeExternalPlugin('logseq-plugin-vim-shortcuts.commands.vim-shortcut-down-0')
  • feat: Support api of Editor.saveFocusedCodeEditorContent resolved Add logseq.Editor.saveFocusedCodeEditorContent to plugin API #7714
  • feat: Support predicate for DB.datascriptQuery inputs
  • fix: Incorrect hook payload from Editor.registerHighlightContextMenuItem
  • fix: Auto generate key if not exist for provideUI options
  • tests: Windows

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Dec 2, 2022
@xyhp915 xyhp915 changed the title WIP: Enhance/plugin apis x WIP: Enhance/plugin APIs Dec 2, 2022
@tiensonqin tiensonqin changed the title WIP: Enhance/plugin APIs Enhance/plugin APIs Dec 16, 2022
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified the new features.

@andelf andelf merged commit 0203179 into master Dec 19, 2022
@andelf andelf deleted the enhance/plugin-apis-x branch December 19, 2022 12:23
logseq-cldwalker added a commit that referenced this pull request Dec 19, 2022
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 8, 2023
* feat: WIP native cli command support

* Add :shell/command-whitelist option

* Integrate cli to code block

* Add :code-block/command-whitelist option

* fix: size of icon

* improve(shell): cache user shell whitelist on application configures file

* improve(electron): promisify run cli command

* chore(libs): update version

* fix(plugin): incorrect payload of pdf highlights section hook

* improve(plugin): block renderer with specific block uuid

* improve(plugin): expose logger for user lib

* improve(plugin): block hooks type

* improve(plugin): block slot hook with specific block

* improve(plugin): auto generate key for provide UI options

* improve(plugin): style of injected ui container

* improve(plugin): types

* improve(plugin): async messaging api from host to plugin

* improve(plugin): add types

* improve(apis): get external plugin metadata

* improve(apis): invoke external plugin impls

* improve(apis): call external plugin impls for simple commands

* enhance(apis): datascript query api for predicate inputs

* enhance(apis): datascript query api for predicate inputs

* fix(apis): redundant args of datascript query api

* enhance(plugins): position of float ui container

* enhance(plugins): style of setting options

* enhance(plugins): layouts data for float ui

* chore(plugins): update CHANGELOG.md

* improve(apis): add types

* chore: fix some inclusive terms

* improve(apis): types

* chore(plugins): update CHANGELOG.md

* chore(plugins): build libs

* chore: update CHANGELOG.md

* chore: remove experiemental alda integration

* fix(lint): remove unused methods

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Co-authored-by: Andelf <andelf@gmail.com>
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 8, 2023
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 18, 2023
* feat: WIP native cli command support

* Add :shell/command-whitelist option

* Integrate cli to code block

* Add :code-block/command-whitelist option

* fix: size of icon

* improve(shell): cache user shell whitelist on application configures file

* improve(electron): promisify run cli command

* chore(libs): update version

* fix(plugin): incorrect payload of pdf highlights section hook

* improve(plugin): block renderer with specific block uuid

* improve(plugin): expose logger for user lib

* improve(plugin): block hooks type

* improve(plugin): block slot hook with specific block

* improve(plugin): auto generate key for provide UI options

* improve(plugin): style of injected ui container

* improve(plugin): types

* improve(plugin): async messaging api from host to plugin

* improve(plugin): add types

* improve(apis): get external plugin metadata

* improve(apis): invoke external plugin impls

* improve(apis): call external plugin impls for simple commands

* enhance(apis): datascript query api for predicate inputs

* enhance(apis): datascript query api for predicate inputs

* fix(apis): redundant args of datascript query api

* enhance(plugins): position of float ui container

* enhance(plugins): style of setting options

* enhance(plugins): layouts data for float ui

* chore(plugins): update CHANGELOG.md

* improve(apis): add types

* chore: fix some inclusive terms

* improve(apis): types

* chore(plugins): update CHANGELOG.md

* chore(plugins): build libs

* chore: update CHANGELOG.md

* chore: remove experiemental alda integration

* fix(lint): remove unused methods

Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Co-authored-by: Andelf <andelf@gmail.com>
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logseq.Editor.saveFocusedCodeEditorContent to plugin API
4 participants