Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: use mod+g c to git commit instead of c #7609

Merged
merged 1 commit into from Dec 6, 2022

Conversation

tiensonqin
Copy link
Contributor

In general, we should avoid using single char as shortcut, the only exception is for whiteboard actions.

In general, we should avoid using single char as shortcut, the only
exception is for whiteboard actions.
Copy link
Contributor

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin merged commit feb6c26 into master Dec 6, 2022
@tiensonqin tiensonqin deleted the fix/use-g-c-for-git-commit branch December 6, 2022 10:14
@tiensonqin tiensonqin changed the title Deprecate: use g c to git commit instead of c BREAKING CHANGE: use g c to git commit instead of c Dec 6, 2022
@tiensonqin tiensonqin changed the title BREAKING CHANGE: use g c to git commit instead of c BREAKING CHANGE: use mod+g c to git commit instead of c Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants