Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group linked references by parent #7613

Merged
merged 1 commit into from Dec 7, 2022

Conversation

usoonees
Copy link
Contributor

@usoonees usoonees commented Dec 6, 2022

Before version 0.8.2, linked references were grouped by parent, which was really important to me and kept me from upgrading to the latest version.

As can be seen from the following, if there is no group, multiple parents are redundant, and the order of children sometimes is chaotic.

Basic usage, write multiple same link below a block (TODO, OKR etc)

Without group: redundant parents and wrong children order

With group

I check the code difference between v0.8.1 and v0.8.2, it really takes a long time for me to locate the bug. So I only revert some part of code, which might not be the best solution, but it does point out the essential code snippet.

Really hope this could be fixed or be an option in settings, thanks 馃檹

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@mzwlevi
Copy link

mzwlevi commented Dec 6, 2022

Support this solution, by the same problem.

@usoonees
Copy link
Contributor Author

usoonees commented Dec 6, 2022

OH, there is a bug for this PR, can't expand in linked references, but I have no idea how to fix this 馃様

Hope @tiensonqin can help 馃檹

@tiensonqin
Copy link
Contributor

@usoonees Thanks for the PR! I'll look into it tomorrow.

@tiensonqin
Copy link
Contributor

@usoonees I'll merge this PR and create a new one with a fix.

@tiensonqin tiensonqin merged commit 842c139 into logseq:master Dec 7, 2022
@tiensonqin
Copy link
Contributor

#7626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants