Feat: Use tooltips instead of titles on whiteboard buttons #7643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengx17
reviewed
Dec 11, 2022
| <> | ||
| {tooltip} | ||
| <span className="ml-2 keyboard-shortcut"> | ||
| {shortcuts |
There was a problem hiding this comment.
The elements may need to have key props
There was a problem hiding this comment.
Handled. I also eliminated a dom validation warning about a nested buttons.
|
Nice work! |
tiensonqin
force-pushed
the
feature/log-2002-use-tooltips-instead-of-titles
branch
from
52a9ee0
to
ed8067d
Compare
tiensonqin
deleted the
feature/log-2002-use-tooltips-instead-of-titles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged with #7641, because it is going to affect the implementation of this enhancement.
Screencast.from.2022-12-09.12-44-06.webm