Enhance: Refine proxy support; Add proxy support to Logseq Sync #7711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andelf
commented
Dec 13, 2022
•
andelf
commented
- Add Proxy support for Logseq Sync
- Use system proxy when possible
- Use App-scope Proxy for Electron, node-fetch, Logseq Sync
- Refine proxy settings
github-actions
bot
added
the
:type/enhancement
andelf
changed the title
andelf
changed the title
andelf
force-pushed
the
enhance/proxy-selection
branch
2 times, most recently
from
616665b
to
4a44369
Compare
andelf
changed the title
andelf
commented
Dec 15, 2022
src/electron/electron/handler.cljs
Outdated
| (defmethod handle :testProxyUrl [_win [_ url]] | ||
| (let [start-ms (.getTime (js/Date.))] | ||
| (-> (utils/fetch url) | ||
| (p/timeout 5000) |
There was a problem hiding this comment.
Need a more reasonable default proxy timeout value here.
andelf
commented
Dec 15, 2022
src/electron/electron/utils.cljs
Outdated
| (if (and agent-opts (not-empty (:protocol agent-opts))) | ||
| (set-fetch-agent agent-opts) | ||
| (when-let [sess (.. @*win -webContents -session)] | ||
| (p/let [proxy (.resolveProxy sess "https://www.google.com") |
There was a problem hiding this comment.
The "electron-way" to acquire system proxy settings.
Need a more proper URL here, like https://api.logseq.com or AWS's s3 domain.
andelf
commented
Dec 15, 2022
| (for [{:keys [label value selected]} options] | ||
| [:option (cond-> | ||
| {:key label | ||
| :default-value (or value label)} |
There was a problem hiding this comment.
Fix: <option> does not have a default-value.
andelf
changed the title
andelf
force-pushed
the
enhance/proxy-selection
branch
from
7452f70
to
09ad883
Compare
andelf
changed the title
andelf
force-pushed
the
enhance/proxy-selection
branch
from
09ad883
to
60c5168
Compare
|
@tiensonqin @xyhp915 New changes:
|
refactor: use system proxy when possible chore: update yarn.lock
tiensonqin
force-pushed
the
enhance/proxy-selection
branch
from
60c5168
to
d469a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.