New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mod+a to select parent up to the whole page #7803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's awesome! 🎉 |
A bug: In Journals, if the current page is not the newest journal, then |
tiensonqin
force-pushed
the
feat/cmd+a-to-select-up-parents
branch
from
December 26, 2022 04:09
bbcfc27
to
06ca790
Compare
3 tasks
andelf
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It works like a charm.
This commit also fixed the selection when zooming into a specific block.
tiensonqin
force-pushed
the
feat/cmd+a-to-select-up-parents
branch
from
December 29, 2022 14:28
3c7ff04
to
02baa7c
Compare
sallto
pushed a commit
to sallto/logseq
that referenced
this pull request
Jan 8, 2023
mod+a to select parent up to the whole page
sallto
pushed a commit
to sallto/logseq
that referenced
this pull request
Jan 18, 2023
mod+a to select parent up to the whole page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/5646b85dacdf418ba30e148d2b7951b1