Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mod+a to select parent up to the whole page #7803

Merged
merged 5 commits into from Dec 29, 2022

Conversation

tiensonqin
Copy link
Contributor

@Bad3r
Copy link
Collaborator

Bad3r commented Dec 20, 2022

That's awesome! 🎉

@andelf
Copy link
Collaborator

andelf commented Dec 22, 2022

A bug:

In Journals, if the current page is not the newest journal, then mod+a will jump to the newest journal at some level.

@tiensonqin
Copy link
Contributor Author

@andelf fixed by bbcfc27.

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It works like a charm.

@tiensonqin tiensonqin force-pushed the feat/cmd+a-to-select-up-parents branch from 3c7ff04 to 02baa7c Compare December 29, 2022 14:28
@tiensonqin tiensonqin merged commit 1206d54 into master Dec 29, 2022
@tiensonqin tiensonqin deleted the feat/cmd+a-to-select-up-parents branch December 29, 2022 14:29
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 8, 2023
mod+a to select parent up to the whole page
sallto pushed a commit to sallto/logseq that referenced this pull request Jan 18, 2023
mod+a to select parent up to the whole page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants