Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add option to show full blocks in references #8124

Merged
merged 3 commits into from Jan 9, 2023

Conversation

lonyelon
Copy link
Contributor

@lonyelon lonyelon commented Dec 28, 2022

Idea from discussion: #7928

This PR adds the option to allow references to show more than the block title, for those of use who like them more than embeds and don't want the block's children included in our refs.

2022-12-28_18-55_36.mp4

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2022

CLA assistant check
All committers have signed the CLA.

@Bad3r Bad3r requested a review from cnrpman December 28, 2022 00:25
@cnrpman cnrpman added the looking-for-review PRs that requires attention label Dec 28, 2022
@lonyelon lonyelon requested review from cnrpman and Bad3r and removed request for andelf, tiensonqin, xyhp915, logseq-cldwalker, cnrpman and Bad3r December 28, 2022 10:28
@Bad3r Bad3r added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Dec 29, 2022
@Bad3r Bad3r changed the title Add option to show full blocks in references enhancement: Add option to show full blocks in references Dec 29, 2022
@Bad3r Bad3r changed the title enhancement: Add option to show full blocks in references enhance: Add option to show full blocks in references Jan 3, 2023
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bad3r Bad3r added this to the 0.8.16 milestone Jan 5, 2023
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Bad3r Bad3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you @lonyelon and congrats on your first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
looking-for-review PRs that requires attention :type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants