New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor/copy-paste): refactor copy/export in cljs #8530
Conversation
@RCmerci did you test assets export? what is the expected behaviour for local graph assets when exporting? |
|
|
For example, page A has content
|
b2b798e
to
f7df108
Compare
5f434d0
to
dfdc207
Compare
@giuseppedandrea yes, this impl won't add 2 trailing spaces to each line |
ce7a2a6
to
3eac98e
Compare
a9d85c8
to
9b6d7af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! 👍
- remove-emphasis? - remove-page-ref-brackets?
- update replace-block-reference-in-table - replace binding with binding* which doall-recur on result
688141b
to
ddaecee
Compare
Huge performance improvement for copy and export Refactor copy/export in cljs instead of Mldoc
Huge performance improvement for copy and export Refactor copy/export in cljs instead of Mldoc
@RCmerci Currently properties of blocks can't be exported (it behaved like that before your PR). The place to add another one option? The only way to copy all text blocks tree now is via selecting root block and using keyboard: |
@stdword This PR mainly focuses on refactoring the existing code and does not add much new functionality. |
move
copy-as
related codes from mldoc to cljs--
Closes #6351