New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: auto-completion for config editing #8584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andelf
force-pushed
the
feat/autocompletion-for-config-editing
branch
from
February 12, 2023 00:53
5b1aa73
to
9a399a2
Compare
cnrpman
approved these changes
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TODO: Screen out existing keys in the current edn
tiensonqin
force-pushed
the
feat/autocompletion-for-config-editing
branch
from
February 13, 2023 07:34
3defe0d
to
1d96d4f
Compare
Fixed by regexp over the whole document. ugly but works. |
@andelf Great to see a feature by being built off malli schemas! 😎 |
sallto
pushed a commit
to sallto/logseq
that referenced
this pull request
Feb 25, 2023
* feat(editor): add auto-completion for config editing * enhance: filter keys already in file when autocompletion
sallto
pushed a commit
to sallto/logseq
that referenced
this pull request
Feb 25, 2023
* feat(editor): add auto-completion for config editing * enhance: filter keys already in file when autocompletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.edn
cm
toCodeMirror
incode.cljs
according to the same naming rule of JavaScriptKnown Issues:
""
,{}
,[]
after completion, should be in the middle of the enclosureedn
mode, not depending on config file names/pathsScreen.Recording.2023-02-12.at.8.05.39.AM.mov