Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide empty settings description #8739

Merged
merged 2 commits into from Mar 3, 2023

Conversation

yoyurec
Copy link
Contributor

@yoyurec yoyurec commented Mar 2, 2023

If there is no descrition value in config, header looks not good. I've missed this case 馃槙
As there is no (in whole file) checks for empty values, will add just CSS solution

update for #8643

@yoyurec
Copy link
Contributor Author

yoyurec commented Mar 2, 2023

interesting how tests can fail )

@yoyurec yoyurec changed the title hide empty settings descrition hide empty settings description Mar 2, 2023
@xyhp915 xyhp915 self-requested a review March 2, 2023 14:02
Copy link
Collaborator

@xyhp915 xyhp915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@logseq-cldwalker logseq-cldwalker changed the title hide empty settings description fix: hide empty settings description Mar 3, 2023
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoyurec Thanks! 馃憤 馃殺

@logseq-cldwalker logseq-cldwalker merged commit 5d0117b into logseq:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants