Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/plugin beforeunload hook #8768

Merged
merged 2 commits into from Mar 6, 2023
Merged

Fix/plugin beforeunload hook #8768

merged 2 commits into from Mar 6, 2023

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Mar 6, 2023

@xyhp915 xyhp915 requested a review from andelf March 6, 2023 03:58
@xyhp915 xyhp915 requested a review from tiensonqin March 6, 2023 03:58
andelf
andelf approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiensonqin
tiensonqin approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin force-pushed the fix/plugin-beforeunload-hook branch from 8abda6d to eb13811 Compare March 6, 2023 04:05
@tiensonqin tiensonqin merged commit 1df54a6 into master Mar 6, 2023
@tiensonqin tiensonqin deleted the fix/plugin-beforeunload-hook branch March 6, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@tiensonqin tiensonqin tiensonqin approved these changes

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xyhp915 @andelf @tiensonqin