enhance(pdf): UI lag for the case of large highlights data #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
:type/enhancement
tiensonqin
force-pushed
the
enhance/pdf-viewer-lag-with-large-hls
branch
from
4a6c4bb
to
3265d5a
Compare
tiensonqin
force-pushed
the
enhance/pdf-viewer-lag-with-large-hls
branch
from
3265d5a
to
cc8855d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #8735
For this issue, the main reason is that serializing large highlights data to the file system is so slow with clojure.core internal solution. so this PR is trying to do this work with a three-party library https://github.com/brandonbloom/fipp, it's about 2 to 3 times faster than the built-in solution. This PR is a quick patch, not a final solution!