Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance (Whiteboards): UX #8797

Merged
merged 24 commits into from Mar 20, 2023
Merged

Enhance (Whiteboards): UX #8797

merged 24 commits into from Mar 20, 2023

Conversation

sprocketc
Copy link
Collaborator

@sprocketc sprocketc commented Mar 9, 2023

  • Improve zooming performance (try zooming using the scrollbar or the trackpad on a portal heavy board)
  • Auto remove arrows when we delete connected shapes (see video)
  • Create new portals when we Alt+Click on refs in portal elements
  • Enable development toolbar within Logseq
  • Clear brush (select) area on exit to avoid the leftover when we double click and drag at the same time (see image below)

Screenshot from 2023-03-09 18-47-43

Screencast.from.2023-03-10.18-20-44.webm

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Mar 9, 2023
@sprocketc sprocketc marked this pull request as ready for review March 13, 2023 11:04
@sprocketc sprocketc changed the title [WIP] Enhance (Whiteboards): UX Enhance (Whiteboards): UX Mar 13, 2023
Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described! 👍

My only suggestion is how about mod+click instead of alt+click for creating new portals?

@sprocketc
Copy link
Collaborator Author

My only suggestion is how about mod+click instead of alt+click for creating new portals?

@tiensonqin I tried using this, but it's conflicting with block selection.

@tiensonqin
Copy link
Contributor

@sprocketc You mean mod+click to select more blocks when there're already some highlighted blocks, right?

@sprocketc
Copy link
Collaborator Author

@tiensonqin Yeah, sometimes it creates a new portal, sometimes it highlights the block and sometimes it does both. I couldn't make it work consistently.

@tiensonqin
Copy link
Contributor

@sprocketc Yes, the block's on-mouse-down event will be triggered earlier than the page ref's on-mouse-up event.
I think we can ignore the event in block-content-on-mouse-down if it's a mod+click click on any page ref.
I can push a commit if you'd like.

Something like:

(and meta? (= "A" (gobj/get target "tagName"))
             (dom/has-class? target "page-ref"))

@sprocketc
Copy link
Collaborator Author

@tiensonqin Thanks! That seems to work as expected.

@tiensonqin tiensonqin merged commit 2c987d0 into master Mar 20, 2023
12 checks passed
@tiensonqin tiensonqin deleted the enhance/whiteboards-ux branch March 20, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants