Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): incorrect position of absolute modal on some mobile platforms #8826

Merged
merged 1 commit into from Mar 20, 2023
Merged

fix(ui): incorrect position of absolute modal on some mobile platforms #8826

merged 1 commit into from Mar 20, 2023

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Mar 15, 2023 •
edited

Before

CleanShot 2023-03-15 at 11 29 13@2x

After

CleanShot 2023-03-15 at 12 02 05@2x

@xyhp915 xyhp915 requested review from andelf and tiensonqin and removed request for andelf March 15, 2023 04:03
tiensonqin
tiensonqin approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin merged commit 988a00e into master Mar 20, 2023
5 checks passed
@tiensonqin tiensonqin deleted the fix/position-absolute-modal branch March 20, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiensonqin tiensonqin tiensonqin approved these changes

@andelf andelf Awaiting requested review from andelf

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xyhp915 @tiensonqin