New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add mldoc ast schema #8829
Conversation
@RCmerci Nice! Could you put this in a graph-parser-fn with :malli/schema? If worried about dev performance with :malli/schema, you could also confirm it works in |
@logseq-cldwalker good suggestions! I have moved this schema to ns |
97ea149
to
e35d3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RCmerci Thanks! 👍 ❤️ Looking forward to using this schema. Hope you don't mind I renamed the schema ns to make room for other schemas. Feel to rename to another schema.* if you'd like. I also added a bb task to validate a file's ast or several from logseq-graph-ast. Could be useful for regression testing. Example:
$ logseq-graph-ast /path/to/docs -o asts.edn
$ bb dev:validate-ast asts.edn
Also move mldoc schema to make room for other schemas
e35d3ca
to
61058a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ns logseq.graph-parser.schema
We may be able to use schema to reduce some prewalk/postwalk on ast. @cldwalker @tiensonqin