fix: undo block deletion needs multiple steps #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiensonqin
force-pushed
the
fix/undo-delete-block
branch
from
116f78c
to
ea98097
Compare
tiensonqin
commented
Mar 16, 2023
| :end? true}}) | ||
| new-content (str value "" (:block/content next-block)) | ||
| repo (state/get-current-repo)] | ||
| (outliner-tx/transact! transact-opts |
There was a problem hiding this comment.
We can group multiple operations in the same db transaction with outliner-tx/transact!.
There was a problem hiding this comment.
transact! could be nested too.
RCmerci
reviewed
Mar 16, 2023
| @@ -18,7 +18,7 @@ | |||
| (move-blocks! ...) | |||
| (delete-blocks! ...))" | |||
| [opts & body] | |||
| (assert (map? opts)) | |||
| (assert (or (map? opts) (symbol? opts)) (str "opts is not a map or symbol, type: " (type opts) )) | |||
There was a problem hiding this comment.
better to have a schema for opts? and validate using :malli/schema? (not sure :malli/schema is supported on defmacro)
There was a problem hiding this comment.
Updated b9a0f40
tiensonqin
force-pushed
the
fix/undo-delete-block
branch
2 times, most recently
from
31c1e3a
to
5fe0107
Compare
tiensonqin
force-pushed
the
fix/undo-delete-block
branch
from
5fe0107
to
97a501a
Compare
xyhp915
approved these changes
Mar 21, 2023
tiensonqin
force-pushed
the
fix/undo-delete-block
branch
from
384ccaf
to
05ea6f5
Compare
… component" This reverts commit 9b6b5a6.
tiensonqin
force-pushed
the
fix/undo-delete-block
branch
from
05ea6f5
to
e41e81c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
https://www.loom.com/share/5e0df1e8ca83436ab7b34a22ba25ab8b
After:
https://www.loom.com/share/d443a5528d584fd8b18951ea76a1bae9