New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add config option to handle default block refs expanding behaviour #8839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
-
To avoid additional breaking change to the current behavior (expanding refs), better to provide default value
true
upon having no:ui/auto-expand-block-refs?
provided inconfig.edn
. Entry point for having default value in codebase:
logseq/src/main/frontend/state.cljs
Lines 312 to 321 in d6e1889
(def default-config "Default config for a repo-specific, user config" {:feature/enable-search-remove-accents? true :default-arweave-gateway "https://arweave.net" ;; For flushing the settings of old versions. Don't bump this value. ;; There are only two kinds of graph, one is not upgraded (:legacy) and one is upgraded (:triple-lowbar) ;; For not upgraded graphs, the config will have no key `:file/name-format` ;; Then the default value is applied :file/name-format :legacy}) -
Minor tune to words (optional & non-blocking, suggestion welcome)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, I made some small adjustment to this PR which fix UI error and enhance UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #7802