Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add config option to handle default block refs expanding behaviour #8839

Merged
merged 8 commits into from Mar 17, 2023

Conversation

aiirobyte
Copy link
Contributor

fix #7802

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the fix label Mar 16, 2023
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!

  1. To avoid additional breaking change to the current behavior (expanding refs), better to provide default value true upon having no :ui/auto-expand-block-refs? provided in config.edn. Entry point for having default value in codebase:

    (def default-config
    "Default config for a repo-specific, user config"
    {:feature/enable-search-remove-accents? true
    :default-arweave-gateway "https://arweave.net"
    ;; For flushing the settings of old versions. Don't bump this value.
    ;; There are only two kinds of graph, one is not upgraded (:legacy) and one is upgraded (:triple-lowbar)
    ;; For not upgraded graphs, the config will have no key `:file/name-format`
    ;; Then the default value is applied
    :file/name-format :legacy})

  2. Minor tune to words (optional & non-blocking, suggestion welcome)

src/main/frontend/dicts.cljc Outdated Show resolved Hide resolved
Copy link
Collaborator

@situ2001 situ2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great fix. I will take a look at it. Before that, I recorded a GIF to demonstrate the setting option.

Kapture 2023-03-17 at 13 11 10

You may embed it into the setting page like this.

image

@situ2001
Copy link
Collaborator

Thanks for your work, I made some small adjustment to this PR which fix UI error and enhance UX.

Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@situ2001 situ2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnrpman cnrpman merged commit 0eb25b3 into logseq:master Mar 17, 2023
5 checks passed
@logseq-cldwalker logseq-cldwalker changed the title Add option to handle default block refs expanding behaviour Enhancement: Add config option to handle default block refs expanding behaviour Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block references always automatically expands when moving to any block after update to 0.8.13
4 participants