Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undo cycle todos #8864

Merged
merged 1 commit into from Mar 22, 2023
Merged

fix: undo cycle todos #8864

merged 1 commit into from Mar 22, 2023

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Mar 21, 2023 •
edited

@andelf andelf self-requested a review March 22, 2023 08:48
andelf
andelf approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 7e8b355 into master Mar 22, 2023
5 checks passed
@andelf andelf deleted the fix/undo-cycle-todos branch March 22, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andelf andelf andelf approved these changes

@RCmerci RCmerci RCmerci approved these changes

@cnrpman cnrpman Awaiting requested review from cnrpman

@xyhp915 xyhp915 Awaiting requested review from xyhp915

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiensonqin @andelf @RCmerci