fix: multiple windows clash #8874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiensonqin
force-pushed
the
fix/multiple-windows-clash
branch
from
3ddd083
to
d0478ec
Compare
|
does current e2e-test failure relate to this pr? |
|
@RCmerci not related. |
tiensonqin
force-pushed
the
fix/multiple-windows-clash
branch
from
d0478ec
to
fd0a847
Compare
logseq-cldwalker
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
@tiensonqin Confirmed we no longer have a crash with new window and syncing 🐛 🔨
| @@ -92,11 +92,13 @@ | |||
| (re-render-root! {})) | |||
| ([{:keys [clear-all-query-state?] | |||
| :or {clear-all-query-state? false}}] | |||
| {:post [(nil? %)]} | |||
tiensonqin
force-pushed
the
fix/multiple-windows-clash
branch
from
fd0a847
to
4f99787
Compare
2 tasks
|
I am still seeing this issue after upgrading/reindexing: #8946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.