Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(ux): audio and video player render after upload asset command #8876

Merged
merged 2 commits into from Mar 24, 2023

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Mar 23, 2023

No description provided.

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Mar 23, 2023
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xyhp915 Uploading an audio asset renders the player nicely! 👍 ⏯️ Left one optional suggestion

src/main/frontend/util.cljc Outdated Show resolved Hide resolved
@logseq-cldwalker logseq-cldwalker changed the title enhance(ux): support audio player renderer for the local audio asset enhance(ux): audio and video player render after upload asset command Mar 24, 2023
@logseq-cldwalker logseq-cldwalker merged commit fc3e5ac into master Mar 24, 2023
5 checks passed
@logseq-cldwalker logseq-cldwalker deleted the enhance/support-rich-audio-assets branch March 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants