New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (Whiteboards): Shape index and arrow binding issue #8885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work as described! 🚢
@@ -16,8 +16,9 @@ test('enable whiteboards', async ({ page }) => { | |||
}) | |||
|
|||
test('should display onboarding tour', async ({ page }) => { | |||
// ensure onboarding tour is going to be triggered locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
e67b372
to
5d28d47
Compare
In the future, I hope we can use fractional Indexing for the shapes index and store it in the blocks instead of the page's properties, the current implementation needs to transact all the indexes when adjusting the position of one shape. Another benefit is that it makes real-time collaboration development easier. |
[
or]
to change their order. After changing their original order, navigate to a different page or undo the action. You will see that the index changes are not persisted, and cannot be undone. Reintroduced the index property of shapes to fix persist. If the current index is different from the shape index, we update its nonce. Also addedupdate-shapes-index
to update the order on undo/redo. I removedbump
from page, since it doesn't do anything anymore.