New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (Whiteboards): An attempt to fix most of the remaining issues #8893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sprocketc
commented
Mar 24, 2023
•
edited
edited
- Check if snapshot pages exist (resolves Whiteboard crash in latest nightly #8886)
- Fix breadcrumbs without label (resolves Bugs in display of whiteboard #7087 - not a whiteboards specific issue)
- Maintain original page name when we create a new page within a whiteboard (resolves Changing the name of a page created from whiteboard makes the whiteboard crash #7811)
- Allow scrolling on tools (resolves [Whiteboard] Toolbar in whiteboard can't be scrolled when it is overflowed #8364). This might not be the perfect solution, but it allows access to the tools that overflow the screen.
- This PR also reverts cb2c1f1 that seems to be causing focus issues on inputs. If you click to edit a page title and then click again somewhere in the middle of the input, the focus will be lost. Also, if you try to create a text element on whiteboards, you won't be able to type.
sprocketc
requested review from
logseq-cldwalker and
tiensonqin
and removed request for
logseq-cldwalker
March 24, 2023 15:32
sprocketc
changed the title
Fix (Whiteboards): Click on untitled whiteboard name of nested block crash
Fix (Whiteboards): An attempt to fix most of the remaining issues
Mar 24, 2023
tiensonqin
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! Worked as described! 🚢
This reverts commit cb2c1f1.
tiensonqin
force-pushed
the
fix/whiteboard-issues
branch
from
March 25, 2023 02:40
8417841
to
c44da12
Compare
Will whiteboards be out in the next release after this fix? :) |
@ZeroCommits Sorry for the late reply. Yes, whiteboards are out since 0.9.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.