Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(ui): adapt the login modal size to responsive layout #8920

Merged
merged 1 commit into from Mar 28, 2023

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Mar 28, 2023

Before (iPad)

CleanShot 2023-03-28 at 16 27 26@2x

After

CleanShot 2023-03-28 at 16 27 49@2x

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiensonqin tiensonqin force-pushed the fix/position-of-login-modal-on-ipad branch from ef8c0cf to 362ce96 Compare March 28, 2023 14:53
@tiensonqin tiensonqin merged commit be21406 into master Mar 28, 2023
4 of 5 checks passed
@tiensonqin tiensonqin deleted the fix/position-of-login-modal-on-ipad branch March 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants