Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fs): asset url calculation #8927

Merged
merged 2 commits into from Mar 28, 2023
Merged

fix(fs): asset url calculation #8927

merged 2 commits into from Mar 28, 2023

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Mar 28, 2023

Close #8919

Caused by typo.

@andelf andelf requested a review from cnrpman March 28, 2023 14:22
@andelf andelf mentioned this pull request Mar 28, 2023
Closed
2 tasks
cnrpman
cnrpman approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 1fe084a into master Mar 28, 2023
5 checks passed
@andelf andelf deleted the fix/assets-url branch March 28, 2023 14:36
@cnrpman cnrpman mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengx17 pengx17 pengx17 approved these changes

@cnrpman cnrpman cnrpman approved these changes

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot view or paste images in whiteboard page
3 participants
@andelf @pengx17 @cnrpman