Enhance context menu #8930
Merged
Enhance context menu #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprocketc
requested changes
Mar 30, 2023
There was a problem hiding this comment.
@megayu Impressive work! I appreciate the additional fixes and refactoring ❤️.
There is an issue with the way set-heading-aux! behaves. When we set a fixed heading in markdown mode, we just need to modify the content of the block, to add the corresponding number of #. If we already have a heading set, the new heading is now set as a block property (e.g. heading:: 4). The only case that we need to do that, is when the heading is set to auto, because there is no auto heading in markdown mode.
|
@sprocketc yes, it's a silly mistake, fixed in 8e081f5 |
sprocketc
approved these changes
Mar 30, 2023
bendyorke
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some functions to custom context menu, including
only select current block during open "bullet" context menu, that fix #7689
fix undo heading needs multiple steps