Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fs): open dir with default app #8931

Merged
merged 2 commits into from Mar 28, 2023
Merged

fix(fs): open dir with default app #8931

merged 2 commits into from Mar 28, 2023

Conversation

andelf
Copy link
Collaborator

@andelf andelf commented Mar 28, 2023

Fix #8922

@andelf andelf requested review from Bad3r and cnrpman March 28, 2023 15:35
Bad3r
Bad3r approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@Bad3r Bad3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it on Linux, and it looks good to me. Thank you so much for addressing this issue promptly!

@andelf andelf merged commit 5d4dcff into master Mar 28, 2023
5 checks passed
@andelf andelf deleted the fix/file-open-in-dir branch March 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bad3r Bad3r Bad3r approved these changes

@cnrpman cnrpman Awaiting requested review from cnrpman

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open in directory fails after fs refactor
2 participants
@andelf @Bad3r