Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal blocks paste #8932

Merged
merged 10 commits into from Mar 29, 2023
Merged

fix: internal blocks paste #8932

merged 10 commits into from Mar 29, 2023

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Mar 28, 2023

fix #8924

This PR adds a custom web application/logseq type for the internal paste item in clipboard, check this link for more details on clipboard's web custom formats.

Test:

  • Electron
  • Chrome
  • iOS
  • Android

@tiensonqin tiensonqin marked this pull request as ready for review March 28, 2023 18:00
@tiensonqin tiensonqin added this to the 0.9.1 milestone Mar 28, 2023
Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiensonqin Fix works great! 🐛 ⚡ QA for copy-as and whiteboard looks good. Added a test

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Android.

@andelf andelf merged commit 2a78e72 into master Mar 29, 2023
12 checks passed
@andelf andelf deleted the fix/internal-paste branch March 29, 2023 10:41
@andelf
Copy link
Collaborator

andelf commented May 6, 2023

This breaks mobile pasting.
When compiled under release mode, clipboard access results in a permission error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cutting & Pasting is broken when block contains ID key
3 participants