Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query with breadcrumbs show blocks on wrong hierarchy #8939

Merged
merged 6 commits into from Mar 29, 2023
Merged

fix: query with breadcrumbs show blocks on wrong hierarchy #8939

merged 6 commits into from Mar 29, 2023

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Mar 28, 2023 •
edited

close #5859

Master:
CleanShot 2023-03-29 at 04 44 18@2x

This PR:
CleanShot 2023-03-29 at 05 14 47@2x

This was referenced Mar 28, 2023
Closed
Closed
sprocketc
sprocketc approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@sprocketc sprocketc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'ed this and it seems to work as expected!

Pushed a minor fix to handle the following alignment issue on whiteboards
Screenshot from 2023-03-29 11-41-06

@tiensonqin tiensonqin merged commit 37230c2 into master Mar 29, 2023
5 checks passed
@tiensonqin tiensonqin deleted the fix/query-breadcrumb-hierarchy branch March 29, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprocketc sprocketc sprocketc approved these changes

@andelf andelf Awaiting requested review from andelf

@logseq-cldwalker logseq-cldwalker Awaiting requested review from logseq-cldwalker

Assignees
No one assigned
Labels
:type/bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query with breadcrumbs show blocks on wrong hierarchy
2 participants
@tiensonqin @sprocketc