Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(ux): add an apply button to multiple selects in query builder #9025

Merged
merged 1 commit into from Apr 4, 2023

Conversation

tiensonqin
Copy link
Contributor

CleanShot 2023-04-04 at 14 43 01@2x

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Apr 4, 2023
@andelf andelf changed the title enhance(ux): add an apply button to multiple selects enhance(ux): add an apply button to multiple selects in query builder Apr 4, 2023
Copy link
Collaborator

@xyhp915 xyhp915 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiensonqin Works great! 👍 🚢 I was wanting something like this :)

As an aside, github seems to be buggy. This PR was showing as an 11 file diff when it's only 2:
Screen Shot 2023-04-04 at 11 54 04 AM

@tiensonqin tiensonqin force-pushed the enhance/add-apply-button-to-multiple-selects branch from d1c5fac to 64428da Compare April 4, 2023 15:59
@tiensonqin
Copy link
Contributor Author

@logseq-cldwalker I just force push it again and it seems to be fixed.

@tiensonqin tiensonqin merged commit a1c3804 into master Apr 4, 2023
6 checks passed
@tiensonqin tiensonqin deleted the enhance/add-apply-button-to-multiple-selects branch April 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants