-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autopair quotes & angle brackets; only autopair tilde w/ selection [minor behavior change] #9391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 14, 2023 03:04
c0af5fe
to
bf6c35a
Compare
Bad3r
changed the title
[WIP] feat: autopair quotes, only autopair tilda when text is selected
[WIP] feat: autopair quotes and pipe; only autopair tilda when text is selected
May 14, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
2 times, most recently
from
May 14, 2023 03:57
5fad491
to
be9e833
Compare
Bad3r
changed the title
[WIP] feat: autopair quotes and pipe; only autopair tilda when text is selected
feat: autopair quotes and pipe; only autopair tilde when text is selected
May 14, 2023
Bad3r
changed the title
feat: autopair quotes and pipe; only autopair tilde when text is selected
feat: autopair quotes; only autopair tilde & pipe when text is selected
May 14, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 14, 2023 04:47
7ae9eb9
to
550a563
Compare
Bad3r
changed the title
feat: autopair quotes; only autopair tilde & pipe when text is selected
feat: autopair quotes & angle brackets; only autopair tilde when text is selected
May 15, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
2 times, most recently
from
May 15, 2023 03:34
5ee3e4a
to
4ec5a8b
Compare
Bad3r
changed the title
feat: autopair quotes & angle brackets; only autopair tilde when text is selected
[WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected
May 16, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 24, 2023 18:17
a9fa2d7
to
6743758
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 24, 2023 18:24
6743758
to
b2d26ac
Compare
Bad3r
changed the title
[WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected
feat: autopair quotes & angle brackets; only autopair tilde when text is selected
May 24, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
2 times, most recently
from
May 24, 2023 19:34
c90b00e
to
8a21adc
Compare
Bad3r
changed the title
feat: autopair quotes & angle brackets; only autopair tilde when text is selected
[WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected
May 24, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 24, 2023 21:22
8a21adc
to
74033a9
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
5 times, most recently
from
May 24, 2023 22:56
bf7225c
to
de94ed5
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
May 24, 2023 23:13
de94ed5
to
72b7255
Compare
Bad3r
changed the title
[WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected
feat: autopair quotes & angle brackets; only autopair tilde when text is selected
May 24, 2023
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
6 times, most recently
from
June 12, 2023 04:36
3404e77
to
926a37d
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
June 12, 2023 04:51
926a37d
to
c88324a
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
June 12, 2023 07:46
4ff009d
to
ef71693
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
10 times, most recently
from
June 13, 2023 03:32
42e16e6
to
ed20f2b
Compare
Bad3r
force-pushed
the
enhance/editor-autopair-tilda
branch
from
June 13, 2023 03:46
ed20f2b
to
50dc2d7
Compare
@Bad3r Hi. Chatted with the core team about this and this isn't a contribution we want. It adds more autopairing characters which is counter to what more users have been asking for. If you'd like to work on making autopairing configurable, happy to chat about it in #engineering or a github issue. Once autopairing is configurable, we'd be open to auto-pairing quotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on
breaking change:
~
its auto-paired without text selection even though it doesn't serve any formatting purpose in markdown or org-mode.changelog
strike-through
withstrikethrough
Feature request: