Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autopair quotes & angle brackets; only autopair tilde w/ selection [minor behavior change] #9391

Closed
wants to merge 31 commits into from

Conversation

Bad3r
Copy link
Collaborator

@Bad3r Bad3r commented May 13, 2023

depends on

breaking change:

  • only autopair tilda when text is selected. This looks like an oversight. When pressing ~ its auto-paired without text selection even though it doesn't serve any formatting purpose in markdown or org-mode.

changelog

  • autopair angle brackets
  • autopair single & double quotes
  • autopair tilde only w/ text selection
  • autopair backlash only w/ text selection
  • replace strike-through with strikethrough

Feature request:

@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from c0af5fe to bf6c35a Compare May 14, 2023 03:04
@Bad3r Bad3r changed the title [WIP] feat: autopair quotes, only autopair tilda when text is selected [WIP] feat: autopair quotes and pipe; only autopair tilda when text is selected May 14, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 2 times, most recently from 5fad491 to be9e833 Compare May 14, 2023 03:57
@Bad3r Bad3r changed the title [WIP] feat: autopair quotes and pipe; only autopair tilda when text is selected feat: autopair quotes and pipe; only autopair tilde when text is selected May 14, 2023
@Bad3r Bad3r changed the title feat: autopair quotes and pipe; only autopair tilde when text is selected feat: autopair quotes; only autopair tilde & pipe when text is selected May 14, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from 7ae9eb9 to 550a563 Compare May 14, 2023 04:47
@Bad3r Bad3r changed the title feat: autopair quotes; only autopair tilde & pipe when text is selected feat: autopair quotes & angle brackets; only autopair tilde when text is selected May 15, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 2 times, most recently from 5ee3e4a to 4ec5a8b Compare May 15, 2023 03:34
@Bad3r Bad3r changed the title feat: autopair quotes & angle brackets; only autopair tilde when text is selected [WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected May 16, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from a9fa2d7 to 6743758 Compare May 24, 2023 18:17
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from 6743758 to b2d26ac Compare May 24, 2023 18:24
@Bad3r Bad3r changed the title [WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected feat: autopair quotes & angle brackets; only autopair tilde when text is selected May 24, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 2 times, most recently from c90b00e to 8a21adc Compare May 24, 2023 19:34
@Bad3r Bad3r changed the title feat: autopair quotes & angle brackets; only autopair tilde when text is selected [WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected May 24, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from 8a21adc to 74033a9 Compare May 24, 2023 21:22
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 5 times, most recently from bf7225c to de94ed5 Compare May 24, 2023 22:56
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from de94ed5 to 72b7255 Compare May 24, 2023 23:13
@Bad3r Bad3r changed the title [WIP] feat: autopair quotes & angle brackets; only autopair tilde when text is selected feat: autopair quotes & angle brackets; only autopair tilde when text is selected May 24, 2023
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 6 times, most recently from 3404e77 to 926a37d Compare June 12, 2023 04:36
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from 926a37d to c88324a Compare June 12, 2023 04:51
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from 4ff009d to ef71693 Compare June 12, 2023 07:46
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch 10 times, most recently from 42e16e6 to ed20f2b Compare June 13, 2023 03:32
@Bad3r Bad3r force-pushed the enhance/editor-autopair-tilda branch from ed20f2b to 50dc2d7 Compare June 13, 2023 03:46
@logseq-cldwalker
Copy link
Collaborator

@Bad3r Hi. Chatted with the core team about this and this isn't a contribution we want. It adds more autopairing characters which is counter to what more users have been asking for. If you'd like to work on making autopairing configurable, happy to chat about it in #engineering or a github issue. Once autopairing is configurable, we'd be open to auto-pairing quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
looking-for-review PRs that requires attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants