Fix (Whiteboards): arrow positions on initialization, undo group delete, hover links jumping and other issues #9480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sprocketc
commented
May 24, 2023
•
sprocketc
commented
- cd8e4b8 Fix Quick links component memoization (resolves [Whiteboards] Related page hover link jumps to another block #9436)
- c34d5c9 Cleanup all whiteboard shapes on initialization to fix existing incorrect arrow positions and 3ba55fa update nonce to properly persist updated arrow positions when they are modified (resolves Logseq whiteboard bug #9439 and Failing initial layout of connectors #9511, see this video to reproduce). Also related to this discord message.
- Fix meta-data of ungroup action (resolves Deleting group on whiteboard not undoable #9486)
- 72097e6 Remove empty groups (resolves Error caught by UI! TypeError: Cannot read properties of undefined (reading 'minX') #8938). I don't know how I ended up in this state, so there are no reproduce steps here. You would have to manually edit the edn file to remove the children, without changing the group element. Empty groups are invalid, and since their bounds are calculated based on their children's bounds, this can crash the application. I need to figure out how this happened, but we need a way to remove the existing empty groups anyway.
sprocketc
changed the title
sprocketc
changed the title
sprocketc
changed the title
|
@sprocketc I took myself for now since this is wip and I get notified on every git push. Feel free to ping when this is ready for review |
2 tasks
logseq-cldwalker
approved these changes
May 26, 2023
There was a problem hiding this comment.
@sprocketc Nice fixes! 🐛 ⚡ Confirmed the ungroup deletion bug and the hover links bug
| @@ -126,6 +126,37 @@ test('clone the rectangle', async ({ page }) => { | |||
| await expect(page.locator('.logseq-tldraw .tl-box-container')).toHaveCount(2) | |||
| }) | |||
|
|
|||
| test('group the rectangles', async ({ page }) => { | |||
2 tasks
2 tasks
logseq-cldwalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.