Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance (Whiteboards): Auto pan triggers earlier and works for more platforms #9573

Merged
merged 3 commits into from Jun 2, 2023

Conversation

sprocketc
Copy link
Collaborator

@sprocketc sprocketc commented Jun 2, 2023

This is just a minor tweak to auto panning, introduced on #8611
We won't have to move the pointer out of canvas to trigger the auto pan. Moving it close to the canvas bounds will also pan to the mouse position. That would allow to use this on mobile devices and on certain desktop cases.

Screencast.from.2023-06-02.18-39-51.webm

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Jun 2, 2023
@logseq-cldwalker
Copy link
Collaborator

@sprocketc Looks like there's a whiteboard test that has failed twice. Happy to review when CI is green

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sprocketc Enhancement works great on desktop! 👍 🚢

@logseq-cldwalker logseq-cldwalker merged commit 776495d into master Jun 2, 2023
13 checks passed
@logseq-cldwalker logseq-cldwalker deleted the enhance/whiteboards-autopan branch June 2, 2023 19:45
@logseq-cldwalker logseq-cldwalker changed the title Enhance (Whiteboards): Auto pan Enhance (Whiteboards): Auto pan triggers earlier and works for more platforms Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants