Enhance(UX): marketplace #9609
Merged
Enhance(UX): marketplace #9609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…installed plugins
github-actions
bot
added
the
:type/enhancement
Bad3r
reviewed
Jun 15, 2023
| (set-enabled! t) | ||
| (plugin-handler/set-enabled-auto-check-for-updates t) | ||
| (notification/show! | ||
| [:span text [:strong.pl-1 (if t "ON" "OFF")] " !"] |
There was a problem hiding this comment.
the space before "!" is not needed
Bad3r
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
QA'd works as expected 🎉 Been running this PR for a few days in my main Logseq build. Tested the plugin update feature by pushing an update to the Logseq Nord theme.
- disable check auto update (wait)
- push an update to a plugin
- enable auto-check for updates (wait)
- notification to update the plugin appears.
I did not close/restart the instance during the test to ensure it could change state while the app is open. I didn't measure the wait time.
…installed plugins
tiensonqin
force-pushed
the
enhance/marketplace-x
branch
from
5e2fae5
to
c1cdf2a
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
fix #9581
CleanShot.2023-06-09.at.09.56.15.mp4