Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): update playwright config 🔨 #9623

Merged
merged 4 commits into from Jun 14, 2023

Conversation

Bad3r
Copy link
Collaborator

@Bad3r Bad3r commented Jun 10, 2023

This PR updates the playwright tests config.

Changelog:

  • Add some documentation
  • Use GitHub reporter for the CI and the default list reporter locally
    • for GitHub Actions CI to generate annotations, plus a concise 'dot'.
  • Add a failsafe

@Bad3r Bad3r force-pushed the dev/e2e/enhance-config branch 5 times, most recently from d43e7eb to 690c963 Compare June 10, 2023 12:11
@andelf andelf self-requested a review June 12, 2023 06:13

// Retry on CI only.
// This will reduce the risk of false negatives when running on CI.
retries: process.env.CI ? 2 : 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always better to fail early than to waste time retrying when tests fail. This is especially important because when e2e tests fail, the editor state can become unpredictable. Therefore, it's best to catch and address the issue at the earliest possible stage to avoid any unnecessary complications.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andelf that's a fair point. The optimal scenario is that tests should be completely independent of each other; in that case, retrying the test won't be an issue since the app state is independent between each test.

I do agree that It's best to address the flakiness in code instead of depending on the retries, though. I will remove it.

@Bad3r Bad3r force-pushed the dev/e2e/enhance-config branch 3 times, most recently from 2ef0f6c to 3e89bb5 Compare June 12, 2023 22:01
@Bad3r Bad3r requested a review from andelf June 12, 2023 22:42
@Bad3r
Copy link
Collaborator Author

Bad3r commented Jun 12, 2023

@andelf the other changes aren't major. Please feel free to merge or close.

@andelf andelf merged commit bc57766 into logseq:master Jun 14, 2023
6 checks passed
@logseq-cldwalker logseq-cldwalker changed the title enhance(e2e): update playwright config 🔨 chore(e2e): update playwright config 🔨 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants