New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): update playwright config 🔨 #9623
Conversation
d43e7eb
to
690c963
Compare
playwright.config.ts
Outdated
|
||
// Retry on CI only. | ||
// This will reduce the risk of false negatives when running on CI. | ||
retries: process.env.CI ? 2 : 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always better to fail early than to waste time retrying when tests fail. This is especially important because when e2e tests fail, the editor state can become unpredictable. Therefore, it's best to catch and address the issue at the earliest possible stage to avoid any unnecessary complications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andelf that's a fair point. The optimal scenario is that tests should be completely independent of each other; in that case, retrying the test won't be an issue since the app state is independent between each test.
I do agree that It's best to address the flakiness in code instead of depending on the retries, though. I will remove it.
690c963
to
0b1e406
Compare
2ef0f6c
to
3e89bb5
Compare
3e89bb5
to
2ea00cb
Compare
@andelf the other changes aren't major. Please feel free to merge or close. |
This PR updates the playwright tests config.
Changelog: