Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): polish the plugin settings modal #9669

Merged
merged 1 commit into from Jun 15, 2023

Conversation

xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Jun 15, 2023

Copy link
Contributor

@tiensonqin tiensonqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@tiensonqin tiensonqin merged commit 52c3278 into master Jun 15, 2023
4 of 5 checks passed
@tiensonqin tiensonqin deleted the fix/ui-of-plugin-settings branch June 15, 2023 16:30
@Bad3r
Copy link
Collaborator

Bad3r commented Jun 15, 2023

hmm sorry but I am not seeing the difference. I tested the merged master. The space between the word "Plugins" and the top bar is small and the plugins feel too close to each other:
_opt_logseq-desktop-git_resources_app_electron html

Edit: never mind. Now it works as expected:
_opt_logseq-desktop-git_resources_app_electron html

Thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing margin in Plugins Settings menu
3 participants