Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace 'presentation' with 'view as slides' [minor change] #9681

Merged
merged 4 commits into from Jun 23, 2023

Conversation

Bad3r
Copy link
Collaborator

@Bad3r Bad3r commented Jun 16, 2023

Issue:
The term 'Presentation' in the three-dot menu does not match user documentation and could be improved.

Background:
This issue was brought up on Discord and discussed with @scheinriese. After careful consideration, we both concluded that 'Slide' is a better term than 'Presentation'. However, we couldn't decide whether Logseq should use 'Slide View' or 'Slide Show'.

Solution:
Considering that Logseq already uses the term 'view' in 'Graph view', I opted for 'Slide view'.
_opt_logseq-desktop-git_resources_app_electron html

Changelog:

  • Replace the term 'Presentation' with 'Slide view'
  • Invalidate old translation (CC: @logseq-cldwalker, not sure if I am doing this correctly)
  • update function names to reflect the change

@scheinriese
Copy link
Contributor

I think Slide view works in most contexts to be coherent with Graph view and other view types we might add in the future. But in this menu most menu points start with a verb. So in the context of this screenshot i would say View as slides. Only problem is that maybe it adds a case of managing singular/plural in some situation.

@Bad3r
Copy link
Collaborator Author

Bad3r commented Jun 19, 2023

I think Slide view works in most contexts to be coherent with Graph view and other view types we might add in the future. But in this menu most menu points start with a verb. So in the context of this screenshot i would say View as slides. Only problem is that maybe it adds a case of managing singular/plural in some situation.

Good point. The singular/plural issue is interesting. Since Logseq doesn't support paging it might be safe to go with 'View as slide' as in 'View page as slide'.

Alternatively, "Start Presentation" could be a great choice as well. It's an action-oriented phrase that clearly communicates to the user that they are about to begin a slideshow-like view of the content.

@scheinriese
Copy link
Contributor

safe to go with 'View as slide' as in 'View page as slide'. Alternatively, "Start Presentation"

Hmm these are all pretty good. "Start presentation" uses different terminology again, so we should make sure it's coherent if we choose this. i forwarded it to the team, hope to get some more inpiut.

@scheinriese
Copy link
Contributor

@tiensonqin added:

View as slide seems to be more general, for example, we might introduce other views, e.g. view as: slide/whiteboard/table/kanban.

@Bad3r Bad3r changed the title chore: replace 'presentation' with 'slide view' chore: replace 'presentation' with 'view as slide' Jun 19, 2023
@Bad3r
Copy link
Collaborator Author

Bad3r commented Jun 20, 2023

@scheinriese updated it to View as slide

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bad3r Thanks! 👍 🚢

@@ -152,7 +152,7 @@
:page/logseq-is-having-a-problem "Logseq is having a problem. To try to get it back to a working state, please try the following safe steps in order:"
:page/step "Step {1}"
:page/try "Try"
:page/presentation-mode "Presentation"
:page/slide-view "View as slide"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature displays multiple slides, not a single one, so tweaking wording to make this accurate

@@ -33,7 +33,6 @@
:right-side-bar/flashcards "Cartes-mémoire"
:right-side-bar/new-page "Nouvelle page"
:left-side-bar/journals "Journaux"
:page/presentation-mode "Mode présentation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing these. Looks like these all had outdated translations anyway as they were translating "Presentation mode"

@logseq-cldwalker logseq-cldwalker changed the title chore: replace 'presentation' with 'view as slide' chore: replace 'presentation' with 'view as slides' Jun 23, 2023
@logseq-cldwalker logseq-cldwalker changed the title chore: replace 'presentation' with 'view as slides' chore: replace 'presentation' with 'view as slides' [minor change] Jun 23, 2023
@logseq-cldwalker logseq-cldwalker merged commit 4949a19 into logseq:master Jun 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants