New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace 'presentation' with 'view as slides' [minor change] #9681
Conversation
I think |
Good point. The singular/plural issue is interesting. Since Logseq doesn't support paging it might be safe to go with 'View as slide' as in 'View page as slide'. Alternatively, "Start Presentation" could be a great choice as well. It's an action-oriented phrase that clearly communicates to the user that they are about to begin a slideshow-like view of the content. |
Hmm these are all pretty good. "Start presentation" uses different terminology again, so we should make sure it's coherent if we choose this. i forwarded it to the team, hope to get some more inpiut. |
@tiensonqin added:
|
52570b2
to
e44afdd
Compare
@scheinriese updated it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bad3r Thanks! 👍 🚢
src/resources/dicts/en.edn
Outdated
@@ -152,7 +152,7 @@ | |||
:page/logseq-is-having-a-problem "Logseq is having a problem. To try to get it back to a working state, please try the following safe steps in order:" | |||
:page/step "Step {1}" | |||
:page/try "Try" | |||
:page/presentation-mode "Presentation" | |||
:page/slide-view "View as slide" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature displays multiple slides, not a single one, so tweaking wording to make this accurate
@@ -33,7 +33,6 @@ | |||
:right-side-bar/flashcards "Cartes-mémoire" | |||
:right-side-bar/new-page "Nouvelle page" | |||
:left-side-bar/journals "Journaux" | |||
:page/presentation-mode "Mode présentation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing these. Looks like these all had outdated translations anyway as they were translating "Presentation mode"
Issue:
The term 'Presentation' in the three-dot menu does not match user documentation and could be improved.
Background:
This issue was brought up on Discord and discussed with @scheinriese. After careful consideration, we both concluded that 'Slide' is a better term than 'Presentation'. However, we couldn't decide whether Logseq should use 'Slide View' or 'Slide Show'.
Solution:
Considering that Logseq already uses the term 'view' in 'Graph view', I opted for 'Slide view'.
Changelog: