Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enhance: Main container #9971

Closed
wants to merge 29 commits into from

Conversation

sprocketc
Copy link
Collaborator

@sprocketc sprocketc commented Aug 2, 2023

Note for reviewers: This enhancement (along with #9846 & #9880), is changing the way we use elevation backgrounds. Although the enhancements should work on both theme modes, you are advised to mainly test this on our default dark theme. The problem with our light theme is that the shade of the elevated backgrounds should be inverted. The higher we you go, the lighter the background should be (see our color-level css class). We are going to make this change on a theme related PR. It would also be nice if we could release the right/left/center enhancements together, because they are all part of the same concept.

  • Handle elevation background. Using the color-level class should ensure that nested elevated blocks will be properly rendered.
  • Move page actions from header dropdown to a dedicated menu next to the page title (this one is the reason I added [minor change] to the title). This decision might be questionable when we view single pages on mobile, because we need the space, and two similar "dots" button will be close to each other. We can make adjustments later on. We can also add dedicated buttons for "favorite" or other actions next to our dots menu.
  • Enhance journals route. Each day should look like an individual pane with its own dropdown. Also changed the way the height of the first day behaves.
  • Add page menus to whiteboard cards on dashboard
  • Minor adjustments on "all pages" route (sticky header)

Screenshot from 2023-08-04 13-39-51

Screenshot from 2023-08-04 13-42-14

Screenshot from 2023-08-04 13-42-40

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Aug 2, 2023
@sprocketc sprocketc changed the title [WIP] Enhance (UI): Main container [WIP] Enhance: Main container Aug 2, 2023
@sprocketc sprocketc added this to the 0.9.14 milestone Aug 2, 2023
@sprocketc sprocketc changed the title [WIP] Enhance: Main container Enhance: Main container Aug 4, 2023
@sprocketc sprocketc marked this pull request as ready for review August 4, 2023 11:35
@sprocketc sprocketc requested a review from andelf August 4, 2023 11:40
@Bad3r
Copy link
Collaborator

Bad3r commented Aug 5, 2023

With everything now in 'cards' (?), it makes it easier to notice the misalignment of UI elements.

I attempted to create a grid screenshot to help explain:
logseq-enhance-center-GRID

  1. The horizontal space between the left window edge and the journal tab is larger than the space between the right window edge and the contents tab in the right sidebar.

  2. The vertical spacing between journal cards, left sidebar cards, and right sidebar cards differ, making the UI feel more complex or overwhelming.

  3. The buttons at the top of the right sidebar (contents, page graph, help) have minimal spacing between them compared to other buttons like the arrow back and arrow forward in the top bar.

  4. the space from the top window border and the journal date (Aug 5th, 2023) feels too large compared to the space at the top of the left sidebar and right sidebar

@Bad3r
Copy link
Collaborator

Bad3r commented Aug 5, 2023

Note that this change makes viewing the content in the right sidebar challenging.
image

The spacing from the right and left do not match and there is too much whitespace at the top:
image

@sprocketc sprocketc added the :type/hold Hold this PR. won't merge for now label Aug 6, 2023
@sprocketc
Copy link
Collaborator Author

Note that this change makes viewing the content in the right sidebar challenging.

That's a valid issue that I missed. Please hold this until it's resolved.

@sprocketc sprocketc removed the :type/hold Hold this PR. won't merge for now label Aug 16, 2023
@sprocketc sprocketc removed this from the 0.9.14 milestone Aug 16, 2023
@sprocketc sprocketc added the :type/hold Hold this PR. won't merge for now label Aug 17, 2023
@sprocketc sprocketc changed the title Enhance: Main container [WIP] Enhance: Main container Aug 17, 2023
@sprocketc sprocketc marked this pull request as draft August 17, 2023 09:02
@andelf andelf added this to the 0.9.15 milestone Aug 17, 2023
@hillsmao
Copy link

I beg you to stop this crazy idea

@sprocketc sprocketc closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:type/enhancement Enhancement to product. Does not affect the overall basic use. :type/hold Hold this PR. won't merge for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants