New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Enhance: Main container #9971
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
:type/enhancement
Enhancement to product. Does not affect the overall basic use.
label
Aug 2, 2023
sprocketc
changed the title
[WIP] Enhance (UI): Main container
[WIP] Enhance: Main container
Aug 2, 2023
That's a valid issue that I missed. Please hold this until it's resolved. |
I beg you to stop this crazy idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:type/enhancement
Enhancement to product. Does not affect the overall basic use.
:type/hold
Hold this PR. won't merge for now
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: This enhancement (along with #9846 & #9880), is changing the way we use elevation backgrounds. Although the enhancements should work on both theme modes, you are advised to mainly test this on our default dark theme. The problem with our light theme is that the shade of the elevated backgrounds should be inverted. The higher we you go, the lighter the background should be (see our
color-level
css class). We are going to make this change on a theme related PR. It would also be nice if we could release the right/left/center enhancements together, because they are all part of the same concept.color-level
class should ensure that nested elevated blocks will be properly rendered.