Fix: json parsing compatibility + freeze event.original value #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
andsel
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.0.0 the mixin shipped with a JSON parsing helper, this method did not parse empty strings in a compatible way.
The desired behavior is to parse
""as aniland raise no error while doing so (to behave likeEvent.from_jsonimpl).Pulling in logstash-plugins/logstash-mixin-event_support#3 on top of #37
Also added
value.dup.freezeforevent.original's value.NOTE: we haven't released 3.1.0 yet - this PR will be part of the same release.